[webkit-reviews] review granted: [Bug 76568] HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading : [Attachment 122987] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victoria Kirst
<vrk at chromium.org>'s request for review:
Bug 76568: HTMLMediaElement should fire 'progress' event before 'idle' if it
was previously loading
https://bugs.webkit.org/show_bug.cgi?id=76568

Attachment 122987: Patch
https://bugs.webkit.org/attachment.cgi?id=122987&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122987&action=review


> Source/WebCore/ChangeLog:12
> +	   No new tests. (OOPS!)

"(OOPS!)" will cause the patch to be rejected by the commit-hook. Please add an
explanation of why there are no new tests.

> Source/WebCore/html/HTMLMediaElement.cpp:1300
> +void HTMLMediaElement::setNetworkStateFromLoadingToIdle()

Nit: I think a better name would be "changeNetworkStateFromLoadingToIdle"