[webkit-reviews] review requested: [Bug 71316] decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...). : [Attachment 123001] Patch plus test KURL decodeEscapeSequence path.

[bugzilla-daemon at webkit.org]

Thomas Sepez <tsepez at chromium.org> has asked  for review:
Bug 71316: decodeEscapeSequences() not correct for some encodings (GBK, Big5,
...).
https://bugs.webkit.org/show_bug.cgi?id=71316

Attachment 123001: Patch plus test KURL decodeEscapeSequence path.
https://bugs.webkit.org/attachment.cgi?id=123001&action=review

------- Additional Comments from Thomas Sepez <tsepez at chromium.org>
Hi AP,

  Its surprisingly hard to find a path that calls into the two-argument form
(non-utf8 decoder) of KURLs decodeURLEscapeSequences, which is why this may
have gone unnoticed, but one place that does it is when we scroll to a
fragment.  The new frame scrolling test fails without this patch.