[webkit-reviews] review denied: [Bug 74487] Support orientation attribute of viewport meta tag. : [Attachment 122703] rebase_patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 05:04:22 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 74487: Support orientation attribute of viewport meta tag.
https://bugs.webkit.org/show_bug.cgi?id=74487

Attachment 122703: rebase_patch
https://bugs.webkit.org/attachment.cgi?id=122703&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122703&action=review


> LayoutTests/fast/viewport/viewport-orientation-expected.txt:3
> +viewport orientation changed to landscape
> +
> +viewport orientation changed to auto

I think this should be checked like any other viewport test... here you are
testing your specific implementation which sends this out as a separate signal


More information about the webkit-reviews mailing list