[webkit-reviews] review requested: [Bug 76253] CSS Shaders: Parse float parameters for the custom() filter syntax : [Attachment 122751] Patch V2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 05:03:53 PST 2012


Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 76253: CSS Shaders: Parse float parameters for the custom() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=76253

Attachment 122751: Patch V2
https://bugs.webkit.org/attachment.cgi?id=122751&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Thanks for the review! 

I've updated the patch. Now I only have one CustomFilterNumberParameter class
for all the float values with a Vector<double, 4> inside.
I've also removed the HashMap and used a simple Vector. I've enforced a sorted
vector in CustomFilterOperation, so that blending of two CustomFilterOperations
can be done fast.


More information about the webkit-reviews mailing list