[webkit-reviews] review granted: [Bug 76296] [Qt] Trigger forcing accelerated compositing from the UI process side. : [Attachment 122478] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 76296: [Qt] Trigger forcing accelerated compositing from the UI process
side.
https://bugs.webkit.org/show_bug.cgi?id=76296

Attachment 122478: Patch
https://bugs.webkit.org/attachment.cgi?id=122478&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122478&action=review


r=me with nitpicks

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:65
> +    // Construct the proxy early to allow messages to be sent to the web
process ASAP.
> +    if (webPageProxy->pageGroup()->preferences()->forceCompositingMode())
> +	   m_layerTreeHostProxy = adoptPtr(new LayerTreeHostProxy(this));
> +#endif

Instead of ASAP say when messages actually need to be sent, e.g. "before page
load".

Put this in PLATFORM(QT), other ports with WebKit2+TextureMapper might not want
this.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:675
>      if (m_layerTreeHost)

You don't need this condition if you assert