[webkit-reviews] review granted: [Bug 76274] [chromium] Refactor canvas, plugin, and video drawing to be more data-driven : [Attachment 122458] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 12:44:06 PST 2012


James Robinson <jamesr at chromium.org> has granted Tim Dresser
<tdresser at chromium.org>'s request for review:
Bug 76274: [chromium] Refactor canvas, plugin, and video drawing to be more
data-driven
https://bugs.webkit.org/show_bug.cgi?id=76274

Attachment 122458: Patch
https://bugs.webkit.org/attachment.cgi?id=122458&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122458&action=review


Looks reasonable. R=me but can't land as is (feel free to ask any committer for
help with landing the final version)

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

this will fail an SVN presubmit check, you need to delete this line and
describe the testing situation (in this case, this looks like a refactor so
existing tests should apply)


More information about the webkit-reviews mailing list