[webkit-reviews] review granted: [Bug 65711] Large SVG text layout performance regression in r81168 : [Attachment 122411] Patch chunk 2, v3

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 65711: Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Attachment 122411: Patch chunk 2, v3
https://bugs.webkit.org/attachment.cgi?id=122411&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=122411&action=review


> Source/WebCore/ChangeLog:26
> +	      stopAtLeaf!=0:
> +	      This will only be used if we

some random looking text fragments here

> Source/WebCore/ChangeLog:47
> +	  
(WebCore::SVGTextMetricsBuilder::measureAllCharactersInLayoutAttributes):

I think you renamed this.

> Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h:41
> +    void measureAllCharactersOfRenderer(RenderSVGInlineText*);

The naming seem slightly inconsistent...

> Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h:52
> +    void initializeMeasurementWithTextRenderer(RenderSVGInlineText*);
> +    void walkTree(RenderObject*, RenderSVGInlineText* stopAtLeaf,
MeasureTextData*);
> +    void measureTextRenderer(RenderSVGInlineText*, MeasureTextData*);

...with these (*Renderer vs. *TextRenderer). The argument type is the same.