[webkit-reviews] review denied: [Bug 76266] Cache RenderStyle pointer in updateBoxModelInfoFromStyle methods : [Attachment 122410] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 76266: Cache RenderStyle pointer in updateBoxModelInfoFromStyle methods
https://bugs.webkit.org/show_bug.cgi?id=76266

Attachment 122410: Patch
https://bugs.webkit.org/attachment.cgi?id=122410&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122410&action=review


> Source/WebCore/ChangeLog:8
> +	   Refactoring code therefore no new tests. (OOPS!)

CQ can't land this automatically with the OOPS intact, you need to remove it.

Also, you should mention why we are doing this, as it's not obvious since
RenderObject::style() is just a trivial inline getter right now.