[webkit-reviews] review denied: [Bug 75762] Pointer Lock: Implement pointer interface : [Attachment 122087] Tests added

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Vincent Scheib
<scheib at chromium.org>'s request for review:
Bug 75762: Pointer Lock: Implement pointer interface
https://bugs.webkit.org/show_bug.cgi?id=75762

Attachment 122087: Tests added
https://bugs.webkit.org/attachment.cgi?id=122087&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122087&action=review


This patch needs to be broken up into smaller bits. Also EWS is sad.

> Source/WebCore/page/PointerLock.cpp:47
> +    return page()->pointerLockController()->lock(target, successCallback,
failureCallback);

Can you not just hold on to the pointerLockController in this class?

> Source/WebCore/page/PointerLockController.h:46
> +    void lock(WebCore::Element* target, PassRefPtr<WebCore::VoidCallback>
successCallback, PassRefPtr<WebCore::VoidCallback> failureCallback);

Why are these guys all namespace-prefixed?

> Source/WebKit/chromium/public/WebWidgetClient.h:130
> +    virtual bool pointerLock(WebKit::WebWidget*) { return false; }

Again, why are these namespace-prefixed?