[webkit-reviews] review requested: [Bug 74352] [skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater : [Attachment 122268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 10:26:39 PST 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 74352: [skia] Track a simple opaque area when painting via
PlatformContextSkia and save in LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=74352

Attachment 122268: Patch
https://bugs.webkit.org/attachment.cgi?id=122268&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
comments addressed.

- Made the asRect() give back an enclosed IntRect so the calculation of that
rect is being tested by the unit tests.
- s/track/did/
- Removed the PlatformContextSkia* member from OpaqueRegionSkia in favour of
just passing it in, so that now the class
  only holds in it an SkRect.


More information about the webkit-reviews mailing list