[webkit-reviews] review granted: [Bug 76169] [Qt] Set the input method hints on the QtQuick item : [Attachment 122230] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 76169: [Qt] Set the input method hints on the QtQuick item
https://bugs.webkit.org/show_bug.cgi?id=76169

Attachment 122230: Patch
https://bugs.webkit.org/attachment.cgi?id=122230&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122230&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:80
> +    eventHandler.reset(new QtWebPageEventHandler(toAPI(webPageProxy), q,
viewportItem));

r=me, but the naming seems a little inconsistent here. In here it's called the
viewportItem and in the event handler it's the webview. I suggest to go for the
latter all the way :)