[webkit-reviews] review granted: [Bug 75284] Web Inspector: CodeGeneratorInspector.py: generate array types. : [Attachment 122219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 06:44:35 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 75284: Web Inspector: CodeGeneratorInspector.py: generate array types.
https://bugs.webkit.org/show_bug.cgi?id=75284

Attachment 122219: Patch
https://bugs.webkit.org/attachment.cgi?id=122219&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122219&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.py:916
> +			       writer.newline("    %s() {}\n" %
fixed_type_name.class_name)

style nit: in generated code there should be a space between {}


More information about the webkit-reviews mailing list