[webkit-reviews] review granted: [Bug 75989] Hang opening movie that requires authentication : [Attachment 121901] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 75989: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989

Attachment 121901: Patch
https://bugs.webkit.org/attachment.cgi?id=121901&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121901&action=review


> Source/WebKit2/ChangeLog:10
> +	   1. When a keychain call is made, the web process send an
asynchronous request message to the UI process,

Typo: send -> sends.

> Source/WebKit2/ChangeLog:13
> +	      avoiding the need to bounce calls to the main thread (since
CoreIPC only allows sending
> +	      synchronous messages from the main thread). Incidentally, this
fixes <rdar://problem/9428041>.
> +	   2. The Web Process now waits (on a condition variable) for a reply
message to come in.

This could be made clearer that it is happening off the main thread.

> Source/WebKit2/Shared/mac/SecKeychainItemRequestData.h:81
> +    struct Attributes : public RefCounted<Attributes> {

This should be ThreadSafeRefCounted.