[webkit-reviews] review granted: [Bug 75842] CSS Filters: apply the filters in RenderLayerBacking::paintIntoLayer when filters cannot be composited in hardware : [Attachment 121855] Patch V4

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 75842: CSS Filters: apply the filters in RenderLayerBacking::paintIntoLayer
when filters cannot be composited in hardware
https://bugs.webkit.org/show_bug.cgi?id=75842

Attachment 121855: Patch V4
https://bugs.webkit.org/attachment.cgi?id=121855&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121855&action=review


> LayoutTests/css3/filters/effect-blur.html:4
> +   
window.layoutTestController.overridePreference("WebKitAcceleratedCompositingEna
bled", "0");

This should not longer be necessary now that bug 75658 was fixed.

> LayoutTests/css3/filters/effect-custom.html:35
> +	   <p style="color: blue">
> +	       Testing that simple custom filters work in software mode. You
should see 5 blocks of colored bars with different effects applied, from left
to right: 
> +	       offset to the right with washed out colors, just offset to the
right with normal colors, 4 smaller blocks attached to the corners, 4 smaller
blocks 
> +	       attached to the corners with washed out colors, normal block
with washed out colors.
> +	       Note: WebGL needs to be enabled for this test to succeed.

It's best to avoid text in pixel tests if possible, because text rendering
differs between OSes and OS versions so much.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:582
> +	   DEFINE_STATIC_LOCAL(FilterOperations, emptyFilterList, ());
> +	   GraphicsLayer::setFilters(emptyFilterList);

I think we should add a clearFilters() method rather than this hack.