[webkit-reviews] review denied: [Bug 74652] [CSS Shaders] Move CustomFilterOperation to the platform layer : [Attachment 121267] Patch V1

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 74652: [CSS Shaders] Move CustomFilterOperation to the platform layer
https://bugs.webkit.org/show_bug.cgi?id=74652

Attachment 121267: Patch V1
https://bugs.webkit.org/attachment.cgi?id=121267&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
Great patch. But I'm really concerned that we have only 3 custom filter tests
in LayoutTests/css3/filters. And two of those are just testing style, so they
don't exercise any of this new code. Please add at least a couple of tests
which exercise the tolerance of missing shaders and the use of the cache (write
two shaders which use the same vertex or fragment shader, etc.).