[webkit-reviews] review requested: [Bug 72830] [Gtk] Regression: text-inserted events lack text inserted and current line : [Attachment 121274] Patch proposal for the remaining issues + updated unit tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 07:38:24 PST 2012
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 72830: [Gtk] Regression: text-inserted events lack text inserted and
current line
https://bugs.webkit.org/show_bug.cgi?id=72830
Attachment 121274: Patch proposal for the remaining issues + updated unit tests
https://bugs.webkit.org/attachment.cgi?id=121274&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
This patch fixed the problem getting the current line, both for single line and
multi-line text controls. It also fixes a problem getting the caret offset for
text controls, which was causing trouble when retrieving the current line in
multi-line text controls (so that's why it's included in this patch too,
instead of a separate bug).
It also updates some caret-related unit tests in testatk.c, so we make sure we
don't break this again in the future.
More information about the webkit-reviews
mailing list