[webkit-reviews] review granted: [Bug 75330] REGRESSION (r92823): Background color not preserved when copying and pasting a table row : [Attachment 121029] fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 75330: REGRESSION (r92823): Background color not preserved when copying and
pasting a table row
https://bugs.webkit.org/show_bug.cgi?id=75330

Attachment 121029: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=121029&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121029&action=review


> Source/WebCore/editing/EditingStyle.cpp:99
> +static PassRefPtr<CSSMutableStyleDeclaration>
editingStyleFromComputedStyle(PassRefPtr<CSSComputedStyleDeclaration> style,
bool includeNonInheritableProperties = false)

Nit: Should we convert includeNonInheritableProperties to an enum?

>
LayoutTests/editing/pasteboard/copy-element-with-conflicting-background-color-f
rom-rule.html:5
> +The pated text should have lightgreen background color.</p>

pated -> pasted