[webkit-reviews] review denied: [Bug 75551] [chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value, causing accelerated content to not display in Aura desktop : [Attachment 121117] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 09:52:24 PST 2012


James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 75551: [chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns
incorrect value, causing accelerated content to not display in Aura desktop
https://bugs.webkit.org/show_bug.cgi?id=75551

Attachment 121117: Patch
https://bugs.webkit.org/attachment.cgi?id=121117&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121117&action=review


Tests please.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Nope, this will fail an SVN presubmit check. You need to remove this line and
ideally write some tests covering this code change.


More information about the webkit-reviews mailing list