[webkit-reviews] review granted: [Bug 75455] ES5 prohibits parseInt from supporting octal : [Attachment 120905] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 20:11:46 PST 2012


Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 75455: ES5 prohibits parseInt from supporting octal
https://bugs.webkit.org/show_bug.cgi?id=75455

Attachment 120905: Fix
https://bugs.webkit.org/attachment.cgi?id=120905&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120905&action=review


>> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:277
>> +	// 8.a. If R < 2 or R > 36, then return NaN.
> 
> Should have a space between // and comment  [whitespace/comments] [4]

There seems to be a weird character in your comment.


More information about the webkit-reviews mailing list