[webkit-reviews] review denied: [Bug 70533] [Chromium] Cull occluded tiles in tiled layers : [Attachment 120750] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 20:10:04 PST 2012


James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 70533: [Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533

Attachment 120750: Patch
https://bugs.webkit.org/attachment.cgi?id=120750&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I don't understand where you are going with a CCQuadCuller base class and
virtual implementations - it seems to be designed for some use case that isn't
in effect here and isn't obvious to me. If you want to have potentially
different cullers, why aren't they just different static functions? with just
one implementation, do you need a base class at all?

a single static function should do just fine here. this looks overengineered.


More information about the webkit-reviews mailing list