[webkit-reviews] review granted: [Bug 74982] [chromium] Estimate pixel count for frame rate control : [Attachment 129250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 12:22:55 PST 2012


James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 74982: [chromium] Estimate pixel count for frame rate control
https://bugs.webkit.org/show_bug.cgi?id=74982

Attachment 129250: Patch
https://bugs.webkit.org/attachment.cgi?id=129250&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129250&action=review


R=me, looks good.

Do we have a good sense for the cost of this? I think it should be pretty low,
right?

> Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp:133
> +	   if (overdrawMetrics) {

can you add a TRACE_EVENT for this block so we can tell if the overdraw
calculation is getting heavy when looking at traces?


More information about the webkit-reviews mailing list