[webkit-reviews] review denied: [Bug 71801] Benchmark using higher-precision timers : [Attachment 116053] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 71801: Benchmark using higher-precision timers
https://bugs.webkit.org/show_bug.cgi?id=71801

Attachment 116053: Patch
https://bugs.webkit.org/attachment.cgi?id=116053&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
We sometimes use command-line SunSpider to compare to other JS engines. So
making a JSC-specific change that materially alters the timings would be
unfortunate. It's great that it is better precision, but it shows a ~9% hit
that does not affect the other engines. Also, as written, it has no fallback
path.

Therefore, I suggest making the new, more precise timing an optional mode
explicitly invoked by a command-line argument to the script. This would allow
the option of more precise measurements without losing the cross-engine
comparison features of the old mode.