[webkit-reviews] review granted: [Bug 79906] Web Inspector: abstract out the common pattern of creating auto-updated locations. : [Attachment 129441] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 09:05:32 PST 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 79906: Web Inspector: abstract out the common pattern of creating
auto-updated locations.
https://bugs.webkit.org/show_bug.cgi?id=79906

Attachment 129441: Patch
https://bugs.webkit.org/attachment.cgi?id=129441&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129441&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:891
> +    formatRawSourceCodeAnchor: function(anchor, uiLocation)

Could you please rename this method to something like formatLiveAnchor now that
it does not depend on rawSourceCode?


More information about the webkit-reviews mailing list