[webkit-reviews] review granted: [Bug 79868] Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin : [Attachment 129385] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 29 08:59:46 PST 2012
Anders Carlsson <andersca at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 79868: Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
https://bugs.webkit.org/show_bug.cgi?id=79868
Attachment 129385: Patch
https://bugs.webkit.org/attachment.cgi?id=129385&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
I think you should change all handleWheelEventPhase functions to just take the
phase enum, that way you'll avoid copying the event object when all you want is
the phase.
Looks great otherwise!
More information about the webkit-reviews
mailing list