[webkit-reviews] review granted: [Bug 79854] [Refactoring] Shadow related attach paths should be in ShadowTree. : [Attachment 129395] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 79854: [Refactoring] Shadow related attach paths should be in ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79854

Attachment 129395: Patch
https://bugs.webkit.org/attachment.cgi?id=129395&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129395&action=review


r=me provided comments below are addressed.

> Source/WebCore/ChangeLog:13
> +	   Even after this change, there are some storange looking parts in
ShadowTree attachment.

Nit: s/storange/strange/. But what is "strange" about them? Could you be more
explicit?

> Source/WebCore/dom/ContainerNode.cpp:770
> +    attachAsNode();

I don't think this is a good change.  Node::attach() is much clearer.

> Source/WebCore/dom/ContainerNode.cpp:779
> -    Node::detach();
> +    detachAsNode();

Ditto.