[webkit-reviews] review denied: [Bug 78596] <shadow> should be rendered correctly : [Attachment 129394] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 28 23:14:01 PST 2012
MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78596: <shadow> should be rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=78596
Attachment 129394: Patch
https://bugs.webkit.org/attachment.cgi?id=129394&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129394&action=review
> Source/WebCore/ChangeLog:19
> +
Please split this up to these three changes if possible.
This patch is simply to big.
You can use this bug as a metabug.
> Source/WebCore/html/shadow/HTMLShadowElement.h:56
> + ShadowRoot* distributedShadowRoot;
Please follow the naming guideline.
More information about the webkit-reviews
mailing list