[webkit-reviews] review granted: [Bug 79496] [GTK] Add GMainLoop and GMainContext to be handled by GRefPtr : [Attachment 128980] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 06:30:33 PST 2012


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 79496: [GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=79496

Attachment 128980: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=128980&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128980&action=review


Looks good, but please fix the small things below.

> Source/WebCore/platform/gtk/RunLoopGtk.cpp:31
> +#include <wtf/gobject/GRefPtr.h>

This include isn't necessary in the header, so why is it necessary here?

> Source/WebKit2/Platform/WorkQueue.h:53
>  typedef struct _GMainContext GMainContext;
>  typedef struct _GMainLoop GMainLoop;

You can remove these now.


More information about the webkit-reviews mailing list