[webkit-reviews] review granted: [Bug 78821] [Qt] API changes to QWebNavigationRequest : [Attachment 129236] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Caio Marcelo de
Oliveira Filho <cmarcelo at webkit.org>'s request for review:
Bug 78821: [Qt] API changes to QWebNavigationRequest
https://bugs.webkit.org/show_bug.cgi?id=78821

Attachment 129236: Patch
https://bugs.webkit.org/attachment.cgi?id=129236&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129236&action=review


> Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest.cpp:29
> +    QWebNavigationRequestPrivate(const QUrl& url, Qt::MouseButton
mouseButton,
> +				    Qt::KeyboardModifiers keyboardModifiers,
QQuickWebView::NavigationType navigationType)

I beliuve that the coding style tell to not split up these up into two lines,
but keep them as one

> Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest.cpp:50
> +QWebNavigationRequest::QWebNavigationRequest(const QUrl& url,
Qt::MouseButton mouseButton,
> +						Qt::KeyboardModifiers
keyboardModifiers, QQuickWebView::NavigationType navigationType, QObject*
parent)

Same here

> Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest_p.h:41
> +    QWebNavigationRequest(const QUrl& url, Qt::MouseButton mouseButton,
Qt::KeyboardModifiers keyboardModifiers,
>			     QQuickWebView::NavigationType navigationType,
QObject* parent = 0);

and here

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:45
> +void QtWebPagePolicyClient::decidePolicyForNavigationAction(const QUrl& url,
Qt::MouseButton mouseButton,
>							      
Qt::KeyboardModifiers keyboardModifiers, QQuickWebView::NavigationType
navigationType, WKFramePolicyListenerRef listener)

And here