[webkit-reviews] review denied: [Bug 79754] [Forms] Spin button sometimes ignores Indeterminate of m_upDownState : [Attachment 129217] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 02:33:10 PST 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 79754: [Forms] Spin button sometimes ignores Indeterminate of m_upDownState
https://bugs.webkit.org/show_bug.cgi?id=79754

Attachment 129217: Patch 2
https://bugs.webkit.org/attachment.cgi?id=129217&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129217&action=review


> Source/WebCore/ChangeLog:14
> +	   m_upDownState can be Indeterminate at mousedown event if mouse
pointer is on
> +	   spin button when it is displayed.
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests. No behavior change.

This patch changes a behavior, and it seems you know how to reproduce the
behavior change.  Please write a test.

Also, usual position of "Reviewed by .." line is just after the bug URL, before
the long description.


More information about the webkit-reviews mailing list