[webkit-reviews] review denied: [Bug 79765] [Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing : [Attachment 129216] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Wei James <james.wei at intel.com>'s
request for review:
Bug 79765: [Chromium] Layout Test webaudio/audiobuffersource-channels.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=79765

Attachment 129216: Patch
https://bugs.webkit.org/attachment.cgi?id=129216&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129216&action=review


I'm not sure this change is correct or not.
We had better roll 109076 out.

> Source/WebCore/ChangeLog:7
> +

Please write a reason why the removing 6 channel limitation is right.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

ChangeLog should not have this OOPS line.

> Source/WebCore/webaudio/AudioNodeOutput.cpp:-40
> -// This is considering that 5.1 (6 channels) is the largest we'll ever deal
with.
> -// It can easily be increased to support more if the web audio specification
is updated.
> -const unsigned MaxNumberOfChannels = 6;

Isn't this specified in the standard?