[webkit-reviews] review denied: [Bug 79659] Optimize Canvas fill and drawImage with SourceIn, DestinationIn, SourceOut, and DestinationAtop using transparencyLayer. : [Attachment 129122] patch v.3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 16:28:37 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 79659: Optimize Canvas fill and drawImage with SourceIn, DestinationIn,
SourceOut, and DestinationAtop using transparencyLayer.
https://bugs.webkit.org/show_bug.cgi?id=79659

Attachment 129122: patch v.3
https://bugs.webkit.org/attachment.cgi?id=129122&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129122&action=review


> Source/JavaScriptCore/wtf/Platform.h:824
> +#if !defined(ENABLE_TRANSPARENCYLAYER_USES_COMPOSITING_OPERATOR)
> +#define ENABLE_TRANSPARENCYLAYER_USES_COMPOSITING_OPERATOR 0
> +#endif

Ugh, this will force a world rebuild for everyone. Just put this in
GraphicsContext.h or somewhere.


More information about the webkit-reviews mailing list