[webkit-reviews] review granted: [Bug 79274] Fix <msubsup> formatting, especially for a tall base, subscript, or superscript : [Attachment 129121] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 79274: Fix <msubsup> formatting, especially for a tall base, subscript, or
superscript
https://bugs.webkit.org/show_bug.cgi?id=79274

Attachment 129121: Patch
https://bugs.webkit.org/attachment.cgi?id=129121&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129121&action=review


> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:152
> +    // FIXME: ASSERT if possible that |superscript| and |subscript| are
really the renderers we
> +    // want, i.e. that our hierarchy hasn't been confused by leftover
anonymous blocks,
> +    // generated content, etc.

Sorry for the slow answer. As mentioned by Dave offline, RenderMathMLSubSup
cannot accept any generated content as it overrides isAllowedChild() to filter
out anything that does not have an associated Element. This comment should be
removed and sorry for the noise.