[webkit-reviews] review granted: [Bug 79697] Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate : [Attachment 129097] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 79697: Move WebCore-internal DOM notification methods from Node to
ContainerNode where appropriate
https://bugs.webkit.org/show_bug.cgi?id=79697

Attachment 129097: Patch
https://bugs.webkit.org/attachment.cgi?id=129097&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129097&action=review


> Source/WebCore/dom/ContainerNode.cpp:817
>      for (Node* child = m_firstChild; child; child = child->nextSibling())
> -	   child->insertedIntoTree(true);
> +	   if (child->isContainerNode())
> +	       toContainerNode(child)->insertedIntoTree(true);

Nit: this for loop needs curly brackets now.

> Source/WebCore/dom/ContainerNode.cpp:826
>      for (Node* child = m_firstChild; child; child = child->nextSibling())
> -	   child->removedFromTree(true);
> +	   if (child->isContainerNode())
> +	       toContainerNode(child)->removedFromTree(true);

Ditto.

> Source/WebCore/dom/ContainerNode.h:91
> +    virtual void insertedIntoTree(bool deep);
> +    virtual void removedFromTree(bool deep);

We should change these to enums (of course in a separate patch) :(