[webkit-reviews] review granted: [Bug 79696] Undefined variable 'current' when running chromium_android.py : [Attachment 129095] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 27 14:05:08 PST 2012
Adam Barth <abarth at webkit.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 79696: Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696
Attachment 129095: patch
https://bugs.webkit.org/attachment.cgi?id=129095&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This is the point when I nag you about adding unit testing for this code. This
sort is bug is really easy to catch with a unit test. I think it's ok to land
this patch without a test, but at some point we'll probably want to add tests.
More information about the webkit-reviews
mailing list