[webkit-reviews] review granted: [Bug 79617] Implement support for op_negate and op_bitnot in the DFG JIT. : [Attachment 129064] Remove op_bitnot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 10:22:39 PST 2012


Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 79617: Implement support for op_negate and op_bitnot in the DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=79617

Attachment 129064: Remove op_bitnot
https://bugs.webkit.org/attachment.cgi?id=129064&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129064&action=review


> Source/JavaScriptCore/ChangeLog:8
> +	   Remove op_bitnop – this is redundant, ~x === x^-1.

Weird unicode character.

> Source/JavaScriptCore/ChangeLog:10
> +

Please put a comment about removing the canUse part of ResultType.


More information about the webkit-reviews mailing list