[webkit-reviews] review granted: [Bug 78608] [BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly : [Attachment 129053] Patch to fix out of bounds selection bug

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted edbaker at rim.com's request for
review:
Bug 78608: [BlackBerry] Dragging a selection handle outside of the content
bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Attachment 129053: Patch to fix out of bounds selection bug
https://bugs.webkit.org/attachment.cgi?id=129053&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129053&action=review


> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:361
> +	   targetPoint = IntPoint(targetPoint.x() < targetFrameRect.x() ?
targetFrameRect.x() : std::min(targetPoint.x(), targetFrameRect.maxX()),
> +		   targetPoint.y() < targetFrameRect.y() ? targetFrameRect.y()
: std::min(targetPoint.y(), targetFrameRect.maxY()));

looks mis-indented.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.h:75
> +WebCore::IntPoint convertPointToFrame(const WebCore::Frame* sourceFrame,
const WebCore::Frame* targetFrame, const WebCore::IntPoint& sourcePoint, const
bool clampToTargetFrame = false);

'const' for the bool is uncommon, but that is ok.