[webkit-reviews] review denied: [Bug 79657] [GTK][libsoup] SoupSession should use system CA : [Attachment 129008] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 27 08:50:05 PST 2012
Martin Robinson <mrobinson at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 79657: [GTK][libsoup] SoupSession should use system CA
https://bugs.webkit.org/show_bug.cgi?id=79657
Attachment 129008: Patch
https://bugs.webkit.org/attachment.cgi?id=129008&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129008&action=review
Looks good, but this needs to be expanded for WKTR.
> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:597
> + /* Do not use strict certificate validation for tests. */
> + g_object_set(session, SOUP_SESSION_SSL_STRICT, FALSE, NULL);
> +
You'll also need to do this for WebKitTestRunner.
More information about the webkit-reviews
mailing list