[webkit-reviews] review denied: [Bug 75464] [EFL][WK2] Add ProcessLauncherEfl.cpp : [Attachment 128954] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 75464: [EFL][WK2] Add ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75464

Attachment 128954: Patch
https://bugs.webkit.org/attachment.cgi?id=128954&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128954&action=review


> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70
> +	   ssize_t result = readlink("/proc/self/exe", readLinkBuffer,
PATH_MAX);
> +
> +	   if (result == -1)
> +	       executablePath = String("/usr/bin");
> +	   else {
> +	       char* executablePathPtr = dirname(readLinkBuffer);
> +	       executablePath = String(executablePathPtr);
> +	   }

readlink() doesn't append a '\0' character. dirname() will read uninitialized
memory in the 'else' branch here.