[webkit-reviews] review denied: [Bug 79625] Move PointerLock APIs from Navigator.idl to NavigatorPointerLock.idl : [Attachment 128956] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 79625: Move PointerLock APIs from Navigator.idl to NavigatorPointerLock.idl
https://bugs.webkit.org/show_bug.cgi?id=79625

Attachment 128956: Patch
https://bugs.webkit.org/attachment.cgi?id=128956&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128956&action=review


> Source/WebCore/Modules/pointerlock/NavigatorPointerLock.idl:25
> +    ] NavigatorPointerLock {

There are a bunch of ENABLED(POINTER_LOCK) ifdefs in WebCore proper.  It might
be better to wait on creating a pointerlock module until we're certain we can
remove them all (or at least the vast majority of them).

> Source/WebCore/page/PointerLock.h:43
> -class PointerLock : public RefCounted<PointerLock>, public DOMWindowProperty
{
> +class PointerLock : public RefCounted<PointerLock>, public
DOMWindowProperty, public NavigatorSupplement {

PointerLock is RefCounted but NavigatorSupplement uses OwnPtr.	This patch will
create a use-after-free bug.  We should make NavigatorPointerLock be the
NavigatorSupplement, which can hold a RefPtr to the PointerLock object.