[webkit-reviews] review granted: [Bug 79518] Web Inspector: Close TabbedPanes on middle click of tab handle : [Attachment 128895] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Dan Beam
<dbeam at chromium.org>'s request for review:
Bug 79518: Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518

Attachment 128895: Patch
https://bugs.webkit.org/attachment.cgi?id=128895&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128895&action=review


Thanks for the fix, I'll fix the ChangeLog and land it.

> Source/WebCore/ChangeLog:6
> +	   Reviewed by Alexander Pavlov.

To avoid further confusion, let me clarify. ChangeLog must contain "Reviewed by
NOBODY (OOPS!)." string. No other OOPS should be there. Reviewer is being
filled in upon landing automatically.

> Source/WebCore/inspector/front-end/TabbedPane.js:618
> +	   if (this._closeable && (event.button === 1 ||
event.target.hasStyleClass("tabbed-pane-header-tab-close-button")))

nit: I would make closeButtonSpan tab's field and compare it here.