[webkit-reviews] review denied: [Bug 79449] Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder : [Attachment 128918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 08:51:14 PST 2012


Philippe Normand <pnormand at igalia.com> has denied Ashod Nakashian
<ashodnakashian at yahoo.com>'s request for review:
Bug 79449: Move FILE_SYSTEM code out of WorkerContext and into the fileapi
folder
https://bugs.webkit.org/show_bug.cgi?id=79449

Attachment 128918: Patch
https://bugs.webkit.org/attachment.cgi?id=128918&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128918&action=review


> Source/WebCore/GNUmakefile.list.am:4871
>	$(WebCore)/fileapi/MetadataCallback.idl
> +	$(WebCore)/fileapi/WorkerContextFileSystem.idl \

This won't work either. Move the backslash to the end of previous line:

$(WebCore)/fileapi/MetadataCallback.idl \
$(WebCore)/fileapi/WorkerContextFileSystem.idl

(without forgetting the tabulations :)


More information about the webkit-reviews mailing list