[webkit-reviews] review granted: [Bug 79371] [CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro : [Attachment 128490] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 79371: [CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
https://bugs.webkit.org/show_bug.cgi?id=79371

Attachment 128490: Patch
https://bugs.webkit.org/attachment.cgi?id=128490&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128490&action=review


> ChangeLog:8
> +	   Add a new macro to handle the inclusion of the platform specifc
*.cmake files.

Nit: specifc => specific

> ChangeLog:9
> +	   In the future this macro should get expanded to handle also feature
specifc

I think it would read better if you change "handle also" to "also handle" or
"handle".

Also, specifc => specific.