[webkit-reviews] review granted: [Bug 79253] WebKit2: implement platform strategy to access Pasteboard in the UI process. : [Attachment 128238] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 79253: WebKit2: implement platform strategy to access Pasteboard in the UI
process.
https://bugs.webkit.org/show_bug.cgi?id=79253

Attachment 128238: Patch
https://bugs.webkit.org/attachment.cgi?id=128238&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128238&action=review


Can sandbox profile be updated now, blocking pasteboard access?

> Source/WebKit2/UIProcess/WebContext.cpp:625
> +#if PLATFORM(MAC)
> +void WebContext::getPasteboardTypes(const String& pasteboardName,
Vector<String>& pasteboardTypes)

Can this code go to WebContextMac.mm instead?

> Source/WebKit2/UIProcess/WebContext.cpp:642
> +    RefPtr<WebCore::SharedBuffer> buffer =
PlatformPasteboard(pasteboardName).bufferForType(pasteboardType);

Is this WebCore:: prefix needed?