[webkit-reviews] review granted: [Bug 79114] MediaStream API: Adding a mock for PeerConnectionHandler : [Attachment 127980] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 79114: MediaStream API: Adding a mock for PeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=79114

Attachment 127980: Patch
https://bugs.webkit.org/attachment.cgi?id=127980&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127980&action=review


> Source/WebCore/mediastream/PeerConnection.h:56
> +    // Name and values of the enum must match the corressponding constants
in the PeerConnection.idl file.

Presumably the compiler enforces this with a COMPILE_ASSERT.

> Source/WebKit/chromium/src/WebPeerConnectionHandlerMock.cpp:56
> +WebPeerConnectionHandlerMock:: ~WebPeerConnectionHandlerMock()

Extra space after the ::