[webkit-reviews] review granted: [Bug 61068] MediaStream API: add getUserMedia mock result manipulation to the LayoutTestController : [Attachment 127785] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 61068: MediaStream API: add getUserMedia mock result manipulation to the
LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61068

Attachment 127785: Patch
https://bugs.webkit.org/attachment.cgi?id=127785&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127785&action=review


One naming nit below, but I don't think its worth re-spinning this patch. 
Please feel free to address it in a follow-up patch if you think it's worth
changing.

> Source/WebKit/chromium/src/WebUserMediaClientMock.cpp:32
> +#if ENABLE(MEDIA_STREAM)

Missing a blank line above here.

> Source/WebKit/chromium/src/WebUserMediaClientMock.cpp:64
> +    m_private->setGetUserMediaResult(allowAudio, allowVideo);

I wonder if this would read better as "setUserMediaResult".

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:187
> +    bindMethod("setMockGetUserMediaResult",
&LayoutTestController::setMockGetUserMediaResult);

This would then be setMockUserMediaResult, which would make sense.