[webkit-reviews] review granted: [Bug 79172] Having a drop handler prevents navigation on drop even if event is not cancelled : [Attachment 128327] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 79172: Having a drop handler prevents navigation on drop even if event is
not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Attachment 128327: Patch
https://bugs.webkit.org/attachment.cgi?id=128327&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128327&action=review


> LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html:18
> +    log('SUCCESS');

Please use 'PASS' instead to be consistent with other tests.

> LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html:40
> +eventSender.mouseUp();

We should probably add log('FAIL') and a call to notifyDone() here so that the
test will print 'FAIL' instead of timing out when the beforeunload is never
fired.