[webkit-reviews] review denied: [Bug 79078] Add HTML Popup API to Chrome : [Attachment 127918] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 79078: Add HTML Popup API to Chrome
https://bugs.webkit.org/show_bug.cgi?id=79078

Attachment 127918: Patch
https://bugs.webkit.org/attachment.cgi?id=127918&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127918&action=review


This code shouldn't be in Platform.  I'm not sure what you're trying to achieve
so it's a bit hard for me to recommend a better course of action.

>> Source/WebCore/page/Chrome.cpp:561
>> +	return m_client->openHTMLPopup(client, originBoundsInRootView);
> 
> if client() is public, why do we need these on Chrome?

We shouldn't need them.

> Source/WebCore/platform/HTMLPopup.h:39
> +class HTMLPopup {

Things in the Platform directory shouldn't know anything about HTML.  There's
some sort of layering confusion here.