[webkit-reviews] review granted: [Bug 78680] [GTK] change the way of registering DeviceOrientation clients : [Attachment 127586] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 78680: [GTK] change the way of registering DeviceOrientation clients
https://bugs.webkit.org/show_bug.cgi?id=78680

Attachment 127586: Patch
https://bugs.webkit.org/attachment.cgi?id=127586&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127586&action=review


> Source/WebKit/gtk/webkit/webkitwebview.cpp:3460
> +#if ENABLE(DEVICE_ORIENTATION)
> +    WebCore::provideDeviceMotionTo(priv->corePage, new
DeviceMotionClientGtk);
> +    WebCore::provideDeviceOrientationTo(priv->corePage, new
DeviceOrientationClientGtk);
> +#endif
> +

Looks like Qt has some code to use a mock for device orientation. I guess we
could have the same and unskip a few tests, perhaps? ;)