[webkit-reviews] review denied: [Bug 34714] onclick is not reliable for transformed SVG elements : [Attachment 127444] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 34714: onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Attachment 127444: Patch
https://bugs.webkit.org/attachment.cgi?id=127444&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127444&action=review


The failing tests need to be marked in platform/chromium/test_expectations.txt.

BUGWK<YOURBUG>: svg/your/file.svg = IMAGE+TEXT
or = IMAGE (depending on if you expect image+text to fail, or only the image).

The usual process for generating baselines is:
* Amend chromium expectations, to paint the cr-linux EWS green
* Include test results generated on Lion, inclduing pixel test baselines, if
needed
* Land your patch, wait for Gtk/Qt/Win to cycle, then use "webkit-patch
rebaseline" to grab the new results from these platforms, then land them as
follow-up patch.

r- because the test won't work in trunk anymore, due recent changes:

> LayoutTests/svg/hittest/script-tests/svg-small-viewbox.js:54
> +startTest(rootSVGElement, 100, 100);

The testcase is outdated, coded against a version before we switched to the
repaint.js harness. I fear you have to upate it again.
Look at how svg/<xxx>/script-tests/foobar.js tests look now in trunk (no more
startTest, executeTest renamed to repaintTest).
You also have to include repaint.js in your .html file now.