[webkit-reviews] review granted: [Bug 78521] The comment about terminating nulls at the top of CSSParser::lex() is incorrect : [Attachment 127087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 22:55:31 PST 2012


Zoltan Herczeg <zherczeg at webkit.org> has granted Cris Neckar
<cdn at chromium.org>'s request for review:
Bug 78521: The comment about terminating nulls at the top of CSSParser::lex()
is incorrect
https://bugs.webkit.org/show_bug.cgi?id=78521

Attachment 127087: Patch
https://bugs.webkit.org/attachment.cgi?id=127087&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
The double NULL originated from flex. The last comment here explains it:

http://stackoverflow.com/questions/1909166/how-to-parse-from-a-string-rather-th
an-a-file

When I started working on the lexer, I kept this behaviour first. Later I
realized I didn't need double NULL terminator, but the comment was remained and
the comment parsing was wrong.


More information about the webkit-reviews mailing list